snuyanzin commented on code in PR #19780:
URL: https://github.com/apache/flink/pull/19780#discussion_r989823634
##########
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java:
##########
@@ -24,50 +24,52 @@
import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputSerializer;
import org.apache.flink.core.memory.DataOutputView;
-import org.apache.flink.util.TestLogger;
+import org.apache.flink.util.TestLoggerExtension;
+import org.assertj.core.api.HamcrestCondition;
import org.hamcrest.Matcher;
-import org.junit.Ignore;
-import org.junit.Test;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
+import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+import static org.assertj.core.api.Assumptions.assumeThat;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assume.assumeThat;
/**
* A test base for testing {@link TypeSerializer} upgrades.
*
- * <p>You can run {@link #generateTestSetupFiles()} on a Flink branch to
(re-)generate the test data
- * files.
+ * <p>You can run {@link
+ *
#generateTestSetupFiles(org.apache.flink.api.common.typeutils.TypeSerializerUpgradeTestBase.TestSpecification)}
+ * on a Flink branch to (re-)generate the test data files.
*/
-public abstract class TypeSerializerUpgradeTestBase<PreviousElementT,
UpgradedElementT>
- extends TestLogger {
+@ExtendWith(TestLoggerExtension.class)
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+public abstract class TypeSerializerUpgradeTestBase<PreviousElementT,
UpgradedElementT> {
public static final FlinkVersion CURRENT_VERSION = FlinkVersion.v1_15;
public static final Set<FlinkVersion> MIGRATION_VERSIONS =
FlinkVersion.rangeOf(FlinkVersion.v1_11, CURRENT_VERSION);
- private final TestSpecification<PreviousElementT, UpgradedElementT>
testSpecification;
-
- protected TypeSerializerUpgradeTestBase(
- TestSpecification<PreviousElementT, UpgradedElementT>
testSpecification) {
- this.testSpecification = checkNotNull(testSpecification);
- }
-
//
------------------------------------------------------------------------------
// APIs
//
------------------------------------------------------------------------------
+ public abstract Collection<TestSpecification<?, ?>> testData() throws
Exception;
Review Comment:
Initially I thought that it should be `testData` since this name is used in
other tests for testing but your point is valid.
Thanks, renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
