snuyanzin commented on code in PR #19780:
URL: https://github.com/apache/flink/pull/19780#discussion_r988900830
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkStateSerializerUpgradeTest.java:
##########
@@ -39,22 +37,12 @@
/**
* A {@link TypeSerializerUpgradeTestBase} for {@link
TwoPhaseCommitSinkFunction.StateSerializer}.
*/
-@RunWith(Parameterized.class)
public class TwoPhaseCommitSinkStateSerializerUpgradeTest
Review Comment:
junit5 has issues if it is not public
```
java.lang.IllegalAccessError: tried to access class
org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkStateSerializerUpgradeTest
from class
org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkStateSerializerUpgradeTest$TwoPhaseCommitSinkStateSerializerVerifier$generated2$
at
org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkStateSerializerUpgradeTest$TwoPhaseCommitSinkStateSerializerVerifier$generated2$.createUpgradedSerializer(TwoPhaseCommitSinkStateSerializerUpgradeTest.java:103)
at
org.apache.flink.api.common.typeutils.TypeSerializerUpgradeTestBase$ClassLoaderSafeUpgradeVerifier.createUpgradedSerializer(TypeSerializerUpgradeTestBase.java:171)
at
org.apache.flink.api.common.typeutils.TypeSerializerUpgradeTestBase.upgradedSerializerIsValidAfterMigration(TypeSerializerUpgradeTestBase.java:342)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
