snuyanzin commented on code in PR #19780:
URL: https://github.com/apache/flink/pull/19780#discussion_r988892634


##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializerUpgradeTest.java:
##########
@@ -37,17 +35,10 @@
 import static org.hamcrest.Matchers.is;
 
 /** A {@link TypeSerializerUpgradeTestBase} for {@link LinkedListSerializer}. 
*/
-@RunWith(Parameterized.class)
 public class LinkedListSerializerUpgradeTest

Review Comment:
   junit5 has issues if it is not public
   ```
   java.lang.IllegalAccessError: tried to access class 
org.apache.flink.table.runtime.typeutils.LinkedListSerializerUpgradeTest from 
class 
org.apache.flink.table.runtime.typeutils.LinkedListSerializerUpgradeTest$LinkedListSerializerVerifier$generated2$
   
        at 
org.apache.flink.table.runtime.typeutils.LinkedListSerializerUpgradeTest$LinkedListSerializerVerifier$generated2$.createUpgradedSerializer(LinkedListSerializerUpgradeTest.java:99)
        at 
org.apache.flink.api.common.typeutils.TypeSerializerUpgradeTestBase$ClassLoaderSafeUpgradeVerifier.createUpgradedSerializer(TypeSerializerUpgradeTestBase.java:171)
        at 
org.apache.flink.api.common.typeutils.TypeSerializerUpgradeTestBase.upgradedSerializerIsValidAfterMigration(TypeSerializerUpgradeTestBase.java:342)
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to