zentol commented on code in PR #21012:
URL: https://github.com/apache/flink/pull/21012#discussion_r993456043
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java:
##########
@@ -90,7 +90,6 @@ static void setup(@TempDir File tempDir) throws Exception {
Files.copy(
jarLocation.resolve(parameterProgramWithEagerSink),
jarDir.resolve("program-with-eager-sink.jar"));
-
Review Comment:
revert
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java:
##########
@@ -92,7 +93,20 @@ public CompletableFuture<JarRunResponseBody> handleRequest(
@Nonnull final DispatcherGateway gateway)
throws RestHandlerException {
- final Configuration effectiveConfiguration = new
Configuration(configuration);
+ Map<String, String> requestJobFlinkConfig =
+ HandlerRequestUtils.fromRequestBodyOrQueryParameter(
+ (request.getRequestBody()).getFlinkConfiguration(),
+ () -> null,
+ null,
+ this.log);
+ Configuration effectiveConfiguration;
+ if (requestJobFlinkConfig != null) {
+ effectiveConfiguration = new Configuration();
+ requestJobFlinkConfig.forEach(effectiveConfiguration::setString);
Review Comment:
In this case we completely ignore `this.configuration` which doesn't correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
