RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1004510730
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java:
##########
@@ -112,26 +109,27 @@ public class ParquetRowDataWriterTest {
TypeConversions.fromLogicalToDataType(ROW_TYPE));
@Test
- public void testTypes() throws Exception {
+ void testTypes(@TempDir java.nio.file.Path folder) throws Exception {
Review Comment:
If this opinion isn't strongly held, my preference is to use the newer
java.nio.file.* classes where possible (except in the cases where we actually
**need** the {{java.io.File}} for working with legacy APIs, of course). It
looks like this is the tendency in the Flink code as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
