RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1008315366
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java:
##########
@@ -79,14 +92,14 @@ public static void setup() throws IOException {
createParquetFile(
AvroParquetWriters.forGenericRecord(schema),
-
Path.fromLocalFile(TEMPORARY_FOLDER.newFile(USER_PARQUET_FILE_1)),
+
Path.fromLocalFile(temporaryFolder.resolve(USER_PARQUET_FILE_1).toFile()),
Review Comment:
This isn't a round trip unfortunately -- it's `java.nio.file.Path` to
`java.io.File` to `org.apache.flink.core.fs.Path`.
I think generally, the new `java.nio.file.Path` has many advantages over the
old interfaces -- in this case, the nicer `resolve` method. I can think of a
couple of ways to address this:
1. Add a `fromLocal(java.nio.file.Path in)` to
`org.apache.flink.core.fs.Path`, or
2. Change the test case to use the `new org.apache.flink.core.fs.Path(URI
uri)` constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
