SteNicholas commented on code in PR #357:
URL: https://github.com/apache/flink-table-store/pull/357#discussion_r1016658666
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CatalogOptions.java:
##########
@@ -49,6 +49,12 @@ private CatalogOptions() {}
.noDefaultValue()
.withDescription("Uri of metastore server.");
+ public static final ConfigOption<Boolean> HMS_EXTERNAL =
+ ConfigOptions.key("hms.external")
Review Comment:
Could this introduce the `TableType` enum and `table.type` config option
which default value is `MANAGED_TABLE`? In the `CatalogOptions`, the
`hms.external` is specific for core module.
cc @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
