SteNicholas commented on code in PR #357:
URL: https://github.com/apache/flink-table-store/pull/357#discussion_r1020706975
##########
flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalog.java:
##########
@@ -226,6 +227,13 @@ public void createTable(ObjectPath tablePath, UpdateSchema
updateSchema, boolean
e);
}
Table table = newHmsTable(tablePath);
+
+ if (hiveConf.getEnum(TABLE_TYPE.key(), TableType.MANAGED_TABLE)
Review Comment:
It's better to move this logic to `newHmsTable` which initialzes the `Table`
and sets the parameters of the `Table`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
