[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #357: [FLINK-29922] Support create external table for hive catalog

[GitBox]

SteNicholas commented on code in PR #357:
URL: https://github.com/apache/flink-table-store/pull/357#discussion_r1020706445


##########
flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalog.java:
##########
@@ -226,6 +227,13 @@ public void createTable(ObjectPath tablePath, UpdateSchema 
updateSchema, boolean
                     e);
         }
         Table table = newHmsTable(tablePath);
+
+        if (hiveConf.getEnum(TABLE_TYPE.key(), TableType.MANAGED_TABLE)
+                .equals(TableType.EXTERNAL_TABLE)) {
+            table.setTableType(TableType.EXTERNAL_TABLE.toString());

Review Comment:
   ```suggestion
               table.setTableType(TableType.EXTERNAL_TABLE.name());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org