JingsongLi commented on code in PR #395:
URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1029996540
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/KeyValueFileStoreRead.java:
##########
@@ -169,7 +172,7 @@ public RecordReader<KeyValue> createReader(DataSplit split)
throws IOException {
List<ConcatRecordReader.ReaderSupplier<KeyValue>> sectionReaders =
new ArrayList<>();
MergeFunctionWrapper<KeyValue> mergeFuncWrapper =
- new ReducerMergeFunctionWrapper(mergeFunction.copy());
+ new
ReducerMergeFunctionWrapper(mfFactory.create(valueProjection));
Review Comment:
Yes, I should delete `.copy()`, we have factory now, we don't need to have a
copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
