JingsongLi commented on code in PR #395:
URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030088540
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/DeduplicateMergeFunction.java:
##########
@@ -48,8 +48,17 @@ public KeyValue getResult() {
return latestKv;
}
- @Override
- public MergeFunction<KeyValue> copy() {
- return new DeduplicateMergeFunction();
+ public static MergeFunctionFactory<KeyValue> factory() {
+ return new Factory();
+ }
+
+ private static class Factory implements MergeFunctionFactory<KeyValue> {
+
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public MergeFunction<KeyValue> create(@Nullable int[][] projection) {
+ return new DeduplicateMergeFunction();
Review Comment:
Actually, this class does not require projection relevant information.
In `PartialUpdateMergeFunction`, validation is not required too, because the
`Project` class will throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
