tsreaper commented on code in PR #395:
URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030008452
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/FullChangelogMergeTreeCompactRewriter.java:
##########
@@ -78,7 +78,7 @@ private CompactResult
rewriteFullCompaction(List<List<SortedRun>> sections) thro
runReaders,
keyComparator,
new FullChangelogMergeFunctionWrapper(
- mergeFunction.copy(), maxLevel));
+ mfFactory.create(null), maxLevel));
Review Comment:
Add a default implementation in the interface.
```java
default MergeFunction<T> create() {
return create(null);
}
```
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/FullChangelogMergeTreeCompactRewriter.java:
##########
@@ -78,7 +78,7 @@ private CompactResult
rewriteFullCompaction(List<List<SortedRun>> sections) thro
runReaders,
keyComparator,
new FullChangelogMergeFunctionWrapper(
- mergeFunction.copy(), maxLevel));
+ mfFactory.create(null), maxLevel));
Review Comment:
Add a default implementation in the interface.
```java
default MergeFunction<T> create() {
return create(null);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
