hdulay commented on code in PR #21436:
URL: https://github.com/apache/flink/pull/21436#discussion_r1039003583
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/Pb3ToRowTest.java:
##########
@@ -85,6 +88,8 @@ public void testDeserialization() throws Exception {
assertEquals(1, rowData.getInt(0));
assertEquals(2L, rowData.getLong(1));
+
+ assertEquals(ts.getNanos(), row.getTimestamp(11,
3).getNanoOfMillisecond());
Review Comment:
@maosuhan Yes as I stepped through the ProtobufSQLITCaseTest to add a
timestamp field, I realized this issue goes beyond just source generation and
compilation errors. Is there an example of how to add new data type? I'm
assuming I'll need to somehow map it to the TimestampType logical type. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
