maosuhan commented on code in PR #21436:
URL: https://github.com/apache/flink/pull/21436#discussion_r1039121017


##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/Pb3ToRowTest.java:
##########
@@ -85,6 +88,8 @@ public void testDeserialization() throws Exception {
 
         assertEquals(1, rowData.getInt(0));
         assertEquals(2L, rowData.getLong(1));
+
+        assertEquals(ts.getNanos(), row.getTimestamp(11, 
3).getNanoOfMillisecond());

Review Comment:
   @hdulay Yes, I agree with your idea. RowType must be doable to reflect a 
Timestamp pb type. If you want to make it more easy to use, you can treat 
`google.protobuf.Timestamp` a special type and manually convert Timestamp to 
TimestampData in code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to