MartijnVisser commented on code in PR #21436:
URL: https://github.com/apache/flink/pull/21436#discussion_r1039012360
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/Pb3ToRowTest.java:
##########
@@ -85,6 +88,8 @@ public void testDeserialization() throws Exception {
assertEquals(1, rowData.getInt(0));
assertEquals(2L, rowData.getLong(1));
+
+ assertEquals(ts.getNanos(), row.getTimestamp(11,
3).getNanoOfMillisecond());
Review Comment:
Just to step in: adding a new datatype requires a FLIP and a discussion. Why
can't any of the existing datatypes be reused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
