[GitHub] [flink] 1996fanrui commented on a diff in pull request #21420: [FLINK-30239][rest] Fix the problem that FlameGraph cannot be generated due to using ImmutableSet incorrectly

Mon, 05 Dec 2022 07:03:58 -0800 


1996fanrui commented on code in PR #21420:
URL: https://github.com/apache/flink/pull/21420#discussion_r1039712703


##########
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/threadinfo/JobVertexThreadInfoTracker.java:
##########
@@ -203,7 +203,14 @@ private void triggerThreadInfoSampleInternal(
                                             delayBetweenSamples,
                                             maxThreadInfoDepth));
 
-            sample.whenCompleteAsync(new 
ThreadInfoSampleCompletionCallback(key, vertex), executor);
+            sample.whenCompleteAsync(new 
ThreadInfoSampleCompletionCallback(key, vertex), executor)
+                    .exceptionally(
+                            throwable -> {
+                                LOG.warn(
+                                        "An exception occurred while 
generating the flame graph.",
+                                        throwable);
+                                return null;
+                            });

Review Comment:
   Hi @xintongsong , thanks for your review.
   
   Sorry, I missed that log  before due to that log level is debug.
   
   I changed the log level to error when flame graph generation fails, it's 
useful to trouble-shooting in the future.
   
   <img width="972" alt="image" 
src="https://user-images.githubusercontent.com/38427477/205669346-c28e6bb5-589a-420e-a1c2-43b7ef2ce146.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to