1996fanrui commented on code in PR #21420:
URL: https://github.com/apache/flink/pull/21420#discussion_r1039719559


##########
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/threadinfo/JobVertexThreadInfoTracker.java:
##########
@@ -251,7 +251,7 @@ private void triggerThreadInfoSampleInternal(
         return executionsWithGateways;
     }
 
-    private Map<TaskManagerLocation, ImmutableSet<ExecutionAttemptID>> 
groupExecutionsByLocation(
+    Map<TaskManagerLocation, ImmutableSet<ExecutionAttemptID>> 
groupExecutionsByLocation(

Review Comment:
   Thanks for your suggestion.
   
   I revoked this change, and check the `ImmutableSet<ExecutionAttemptID>` in 
`TestingThreadInfoRequestCoordinator#triggerThreadInfoRequest`. 
   
   It can cover this bug and check the `ImmutableSet<ExecutionAttemptID>` 
during request thread info for all unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to