swathic95 commented on code in PR #481:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1046639775
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/SessionReconciler.java:
##########
@@ -96,6 +96,19 @@ protected void reconcileSpecChange(
Configuration deployConfig,
DiffType type)
throws Exception {
+ if (type == DiffType.SCALE) {
Review Comment:
Since this case was more applicable for SessionReconciler, added the changes
there. But I agree with your point as both JobReconciler and SessionReconciler
is re-using it, we can add it in the parent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
