gyfora commented on code in PR #481:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1047128422
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkServiceTest.java:
##########
@@ -177,11 +177,123 @@ public void testReactiveScale() throws Exception {
.getSpec()
.getFlinkConfiguration()
.remove(JobManagerOptions.SCHEDULER_MODE.key());
- assertFalse(
+ assertTrue(
+ flinkStandaloneService.scale(
+ flinkDeployment.getMetadata(),
+ flinkDeployment.getSpec().getJob(),
+ buildConfig(flinkDeployment, configuration)));
+ }
+
+ @Test
+ public void testTMReplicaScale() throws Exception {
+ var flinkDeployment = TestUtils.buildApplicationCluster();
Review Comment:
would be nice to test this with a session cluster resource where `job =
null`.
You could use `TestUtils.buildSessionCluster()` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
