swathic95 commented on code in PR #481:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1046706450
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -171,11 +170,6 @@ protected void deleteClusterInternal(ObjectMeta meta,
boolean deleteHaConfigmaps
@Override
public boolean scale(ObjectMeta meta, JobSpec jobSpec, Configuration conf)
{
- if (conf.get(JobManagerOptions.SCHEDULER_MODE) == null) {
Review Comment:
Even if there is no scheduler mode enabled , i.e if the scheduler mode is
null, still we should be able to scale the cluster i.e even if the adaptive or
reactive mode is not enabled and only scaling change should allow to only
scale. But let me know your thoughts @gyfora , @morhidi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
