XComp commented on code in PR #21501:
URL: https://github.com/apache/flink/pull/21501#discussion_r1055298739
##########
tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java:
##########
@@ -211,6 +211,7 @@ private static int findNonBinaryFilesContainingText(
// contained in sql-avro-confluent-registry
.filter(path -> !pathStartsWith(path,
"/org/glassfish/jersey/internal"))
// contained in sql-connector-pulsar
+ // while the Pulsar connector is externalized, this is
still needed for PuFlink
Review Comment:
```suggestion
// while the Pulsar connector is externalized, this is
still needed for PyFlink
```
##########
docs/setup_docs.sh:
##########
@@ -36,14 +36,25 @@ echo "Created temporary file" $goModFileLocation/go.mod
currentBranch=$(git rev-parse --abbrev-ref HEAD)
function integrate_connector_docs {
+ local connector ref additional_folders
connector=$1
ref=$2
+ additional_folders=( "${@:3}" )
+
git clone --single-branch --branch ${ref}
https://github.com/apache/flink-connector-${connector}
theme_dir="../themes/connectors"
mkdir -p "${theme_dir}"
- rsync -a flink-connector-${connector}/docs/content* "${theme_dir}/"
+
+ for rsync_folder_subpath in "docs/content*" "${additional_folders[@]}"; do
Review Comment:
```suggestion
for rsync_folder_subpath in "docs/content" "docs/content.zh"
"${additional_folders[@]}"; do
```
sorry; my bad. The if statement doesn't allow the asterix. AFAIU, the
asterix was just used initially to rsync both `docs/content` and
`docs/content.zh`.
##########
flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java:
##########
@@ -73,15 +73,6 @@ public class ConfigurationOptionLocator {
new OptionsClassLocation("flink-clients",
"org.apache.flink.client.cli"),
new OptionsClassLocation(
"flink-table/flink-sql-client",
"org.apache.flink.table.client.config"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.common.config"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.source"),
- new OptionsClassLocation(
- "flink-connectors/flink-connector-pulsar",
- "org.apache.flink.connector.pulsar.sink"),
Review Comment:
Did we create the follow-up ticket?
##########
docs/setup_docs.sh:
##########
@@ -54,6 +65,7 @@ cd tmp
integrate_connector_docs elasticsearch v3.0.0
integrate_connector_docs aws v3.0.0
integrate_connector_docs cassandra v3.0.0
+integrate_connector_docs pulsar main "docs/layouts*"
Review Comment:
```suggestion
integrate_connector_docs pulsar main "docs/layouts"
```
I know that just blindly copied the `layouts*`. So, it's actually my
mistake. Sorry for that. But am I right in assuming that `docs/layouts*` was
just copied from `docs/content*` without a reason? Or why do we need the
asterix here? It appears that there is only a `docs/layout` subfolder in
[flink-connector-pulsar:./docs/](https://github.com/apache/flink-connector-pulsar/tree/main/docs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
