MartijnVisser commented on code in PR #21501:
URL: https://github.com/apache/flink/pull/21501#discussion_r1055396770
##########
docs/setup_docs.sh:
##########
@@ -36,14 +36,25 @@ echo "Created temporary file" $goModFileLocation/go.mod
currentBranch=$(git rev-parse --abbrev-ref HEAD)
function integrate_connector_docs {
+ local connector ref additional_folders
connector=$1
ref=$2
+ additional_folders=( "${@:3}" )
+
git clone --single-branch --branch ${ref}
https://github.com/apache/flink-connector-${connector}
theme_dir="../themes/connectors"
mkdir -p "${theme_dir}"
- rsync -a flink-connector-${connector}/docs/content* "${theme_dir}/"
+
+ for rsync_folder_subpath in "docs/content*" "${additional_folders[@]}"; do
Review Comment:
This was also sloppy on my part, should have tried it locally first 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
