XComp commented on code in PR #21536: URL: https://github.com/apache/flink/pull/21536#discussion_r1055342467
########## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/5b9eed8a-5fb6-4373-98ac-3be2a71941b8: ########## @@ -384,4 +377,4 @@ org.apache.flink.streaming.runtime.operators.windowing.TimestampedValue.getStrea org.apache.flink.streaming.runtime.streamrecord.LatencyMarker.getOperatorId(): Returned leaf type org.apache.flink.runtime.jobgraph.OperatorID does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated org.apache.flink.streaming.runtime.tasks.ProcessingTimeServiceAware.setProcessingTimeService(org.apache.flink.streaming.runtime.tasks.ProcessingTimeService): Argument leaf type org.apache.flink.streaming.runtime.tasks.ProcessingTimeService does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated org.apache.flink.table.operations.QueryOperation.accept(org.apache.flink.table.operations.QueryOperationVisitor): Argument leaf type org.apache.flink.table.operations.QueryOperationVisitor does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated -org.apache.flink.types.parser.FieldParser.getErrorState(): Returned leaf type org.apache.flink.types.parser.FieldParser$ParseErrorState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated \ No newline at end of file +org.apache.flink.types.parser.FieldParser.getErrorState(): Returned leaf type org.apache.flink.types.parser.FieldParser$ParseErrorState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated Review Comment: nit: newline added. But the [Flink code conventions](https://flink.apache.org/contributing/code-style-and-quality-formatting.html#files) actually are in favor of that ¯\_(ツ)_/¯ ########## flink-python/pom.xml: ########## @@ -322,7 +322,7 @@ under the License. <!-- Indirectly accessed in pyflink_gateway_server --> <groupId>org.apache.flink</groupId> <artifactId>flink-connector-jdbc</artifactId> - <version>${project.version}</version> + <version>3.0.0-1.16</version> Review Comment: Is this required to be updated everytime we release a new version of `flink-connector-jdbc`? I'm wondering whether we should add some comment on the update procedure if we want this to stay update to date with the most-recently published connector verison. WDYT? ########## docs/data/sql_connectors.yml: ########## @@ -148,7 +148,7 @@ jdbc: name: JDBC category: connector maven: flink-connector-jdbc - sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/$version/flink-connector-jdbc-$version.jar + sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/1.16.0/flink-connector-jdbc-1.16.0.jar Review Comment: Why don't we use the newly released 3.0.0 version here? :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
