MartijnVisser commented on code in PR #21536:
URL: https://github.com/apache/flink/pull/21536#discussion_r1055404692


##########
flink-python/pom.xml:
##########
@@ -322,7 +322,7 @@ under the License.
                        <!-- Indirectly accessed in pyflink_gateway_server -->
                        <groupId>org.apache.flink</groupId>
                        <artifactId>flink-connector-jdbc</artifactId>
-                       <version>${project.version}</version>
+                       <version>3.0.0-1.16</version>

Review Comment:
   I don't know to be honest, because I don't know the type of tests that 
PyFlink is running with them. We'll need to sync on this with the PyFlink 
maintainers



##########
docs/data/sql_connectors.yml:
##########
@@ -148,7 +148,7 @@ jdbc:
     name: JDBC
     category: connector
     maven: flink-connector-jdbc
-    sql_url: 
https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/$version/flink-connector-jdbc-$version.jar
+    sql_url: 
https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/1.16.0/flink-connector-jdbc-1.16.0.jar

Review Comment:
   Good catch, that's a mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to