gyfora commented on code in PR #493:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057607945
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -122,7 +130,15 @@ public CollectedMetrics getMetricsHistory(
// Add scaling metrics to history if they were computed successfully
scalingMetricHistory.put(clock.instant(), scalingMetrics);
- scalingInformation.updateMetricHistory(currentJobStartTs,
scalingMetricHistory);
+ scalingInformation.updateMetricHistory(currentJobUpdateTs,
scalingMetricHistory);
+
+ if (currentJobUpdateTs
+ .plus(stabilizationDuration)
+ .isAfter(clock.instant().minus(metricsWindowDuration))) {
Review Comment:
Looks good! Please also update the autoscaler doc page section about the
improved configuration
(https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/custom-resource/autoscaler/#stabilization-and-metrics-collection-intervals)
and the example configs in docs and yamls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
