gyfora commented on code in PR #493:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057664132
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -122,7 +130,15 @@ public CollectedMetrics getMetricsHistory(
// Add scaling metrics to history if they were computed successfully
scalingMetricHistory.put(clock.instant(), scalingMetrics);
- scalingInformation.updateMetricHistory(currentJobStartTs,
scalingMetricHistory);
+ scalingInformation.updateMetricHistory(currentJobUpdateTs,
scalingMetricHistory);
+
+ if (currentJobUpdateTs
+ .plus(stabilizationDuration)
+ .isAfter(clock.instant().minus(metricsWindowDuration))) {
Review Comment:
At any point the data rate might suddenly increase (during any scale
operation) the minimum window allows us to react to it. This is not only about
the first time we start the job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
