gyfora commented on code in PR #493:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057676553
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -122,7 +130,15 @@ public CollectedMetrics getMetricsHistory(
// Add scaling metrics to history if they were computed successfully
scalingMetricHistory.put(clock.instant(), scalingMetrics);
- scalingInformation.updateMetricHistory(currentJobStartTs,
scalingMetricHistory);
+ scalingInformation.updateMetricHistory(currentJobUpdateTs,
scalingMetricHistory);
+
+ if (currentJobUpdateTs
+ .plus(stabilizationDuration)
+ .isAfter(clock.instant().minus(metricsWindowDuration))) {
Review Comment:
I think in this early state it’s better to have flexibility with the
configuration and document recommendations than to restrict the behavior. We
still have time to simplify this in the future as we gather working knowledge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
