reswqa commented on code in PR #21560: URL: https://github.com/apache/flink/pull/21560#discussion_r1060265216
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PartialFinishedInputConsumableDecider.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import java.util.Map; +import java.util.Set; +import java.util.function.Function; + +/** + * {@link PartialFinishedInputConsumableDecider} is a special {@link InputConsumableDecider}. The + * input is considered to be consumable: + * + * <ul> + * <li>for hybrid input: when partial producer partitions are finished. + * <li>for blocking input: when all producer partitions are finished. + * </ul> + */ +public class PartialFinishedInputConsumableDecider implements InputConsumableDecider { + public static final int NUM_FINISHED_PARTITIONS_AS_CONSUMABLE = 1; + + @Override + public boolean isInputConsumable( + SchedulingExecutionVertex executionVertex, + Set<ExecutionVertexID> verticesToDeploy, + Map<ConsumedPartitionGroup, Boolean> consumableStatusCache) { + for (ConsumedPartitionGroup consumedPartitionGroup : + executionVertex.getConsumedPartitionGroups()) { + + if (!consumableStatusCache.computeIfAbsent( + consumedPartitionGroup, this::isConsumedPartitionGroupConsumable)) { + return false; + } Review Comment: I think it is reasonable to require all groups to have at least one finished partition. The main reason is that in the case of multiple inputs, if the low priority input is finished first, the downstream cannot consume data even if it is scheduled in advance, which will cause a waste of resources to some extent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
