reswqa commented on code in PR #21560:
URL: https://github.com/apache/flink/pull/21560#discussion_r1060273190
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java:
##########
@@ -762,7 +763,9 @@ private static PartitionInfo createPartitionInfo(
ShuffleDescriptor shuffleDescriptor =
getConsumedPartitionShuffleDescriptor(
consumedPartition,
-
TaskDeploymentDescriptorFactory.PartitionLocationConstraint.MUST_BE_KNOWN);
+
TaskDeploymentDescriptorFactory.PartitionLocationConstraint.MUST_BE_KNOWN,
+ // because partition is already finished, false is
fair enough.
Review Comment:
Because `createPartitionInfo` will only be invoked from
`finishPartitionsAndUpdateConsumers`, which has been already finished this
partition. But in order not to be misused later, I renamed it to
`createFinishedPartitionInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
