reswqa commented on code in PR #21560:
URL: https://github.com/apache/flink/pull/21560#discussion_r1060429247


##########
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.java:
##########
@@ -75,7 +77,7 @@ public class InputGateDeploymentDescriptor implements 
Serializable {
     private transient ShuffleDescriptor[] inputChannels;
 
     /** Serialized value of shuffle descriptors. */
-    private MaybeOffloaded<ShuffleDescriptor[]> serializedInputChannels;
+    private final List<MaybeOffloaded<ShuffleDescriptor>> 
serializedInputChannels;

Review Comment:
   This is indeed a reasonable concerns. I changed this logical to serialize 
`shuffleDescriptors` in batch, and the `IGDD(InputGateDeploymentDescriptor)` 
stores `List<MaybeOffloaded<ShuffleDescriptorAndIndex[]>>`, we can calculates 
all producer's `shuffleDescriptor` from this list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to