tisonkun commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060340966
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -124,6 +124,8 @@ private PulsarSourceOptions() {
" We would automatically commit
the cursor using the given period (in ms).")
.build());
+ /** @deprecated We no longer need transitions for consuming messages. */
Review Comment:
```suggestion
/** @deprecated We no longer need transactions for consuming messages. */
```
?
Also, if this option has no effect, we'd better directly remove it.
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -236,6 +230,8 @@ private PulsarSourceOptions() {
" This argument is required when
constructing the consumer.")
.build());
+ /** @deprecated This config option is no longer supported. */
+ @Deprecated
public static final ConfigOption<SubscriptionType>
PULSAR_SUBSCRIPTION_TYPE =
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
