tisonkun commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060341436
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/SourceConfiguration.java:
##########
@@ -203,12 +175,7 @@ public boolean isEnableMetrics() {
/** Convert the subscription into a readable str. */
public String getSubscriptionDesc() {
- return getSubscriptionName()
- + "("
- + getSubscriptionType()
- + ","
- + getSubscriptionMode()
- + ")";
+ return getSubscriptionName() + "(" + getSubscriptionMode() + ")";
Review Comment:
Maybe we hard code the type as `Exclusive`? I think it's still expressive
and meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
