tisonkun commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060340290
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -177,9 +171,11 @@ public PulsarSourceBuilder<OUT> setSubscriptionName(String
subscriptionName) {
* @return this PulsarSourceBuilder.
* @see <a
href="https://pulsar.apache.org/docs/en/concepts-messaging/#subscriptions";>Pulsar
* Subscriptions</a>
+ * @deprecated We don't support setting the subscription type now.
*/
+ @Deprecated
public PulsarSourceBuilder<OUT> setSubscriptionType(SubscriptionType
subscriptionType) {
Review Comment:
If it's a dummy method, shall we remove these methods? Otherwise, although
users' code doesn't fail on compile, the result is actually unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
