syhily commented on code in PR #10:
URL: 
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060347329


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -236,6 +230,8 @@ private PulsarSourceOptions() {
                                             " This argument is required when 
constructing the consumer.")
                                     .build());
 
+    /** @deprecated This config option is no longer supported. */
+    @Deprecated
     public static final ConfigOption<SubscriptionType> 
PULSAR_SUBSCRIPTION_TYPE =

Review Comment:
   This configure option will be auto remove in generated documentation. And I 
think we can remove it in the next release as above.



##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -236,6 +230,8 @@ private PulsarSourceOptions() {
                                             " This argument is required when 
constructing the consumer.")
                                     .build());
 
+    /** @deprecated This config option is no longer supported. */
+    @Deprecated
     public static final ConfigOption<SubscriptionType> 
PULSAR_SUBSCRIPTION_TYPE =

Review Comment:
   This configure option will be auto removed in generated documentation. And I 
think we can remove it in the next release as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to