syhily commented on code in PR #10:
URL:
https://github.com/apache/flink-connector-pulsar/pull/10#discussion_r1060346224
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -177,9 +171,11 @@ public PulsarSourceBuilder<OUT> setSubscriptionName(String
subscriptionName) {
* @return this PulsarSourceBuilder.
* @see <a
href="https://pulsar.apache.org/docs/en/concepts-messaging/#subscriptions";>Pulsar
* Subscriptions</a>
+ * @deprecated We don't support setting the subscription type now.
*/
+ @Deprecated
public PulsarSourceBuilder<OUT> setSubscriptionType(SubscriptionType
subscriptionType) {
Review Comment:
The
[flink-python](https://github.com/apache/flink/blob/eb017831e67f87fc2c6456c767b64c65d06d0ce9/flink-python/pyflink/datastream/connectors/pulsar.py#L407)
still use this method. We should deprecate this method first. Then we can
remove this method in next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
