GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/2606
Allow custom convergence criterion in delta iterations
As discussed in the Jira issue, this PR contains the following changes:
1. use `TaskConfig.setConvergenceCriterion()` to set the custom,
user-defined convergence criterion (like in the case of bulk iteration)
2. add a new method `TaskConfig.setDefaultConvergeCriterion()` to handle
the default empty workset convergence
â3. check both criteria in
`IterationSynchronizationSinkTask.checkForConvergence()â`
4. expose the custom convergence criterion in `DeltaIteration`
It also contains some minor cleanup and corresponding changes in the
`CollectionExecutor`.
The iteration docs already state that custom convergence is possible, so no
update needed there ;)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vasia/flink flink-3888
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2606
----
commit 41327034ae57d99fdde74bf24838d19b5aee31f3
Author: vasia <[email protected]>
Date: 2016-10-05T11:49:20Z
[FLINK-3888] allow registering a custom convergence criterion in delta
iterations
commit e7ffc368f8542d3afe823b86c23e91379a03e21b
Author: vasia <[email protected]>
Date: 2016-10-05T12:06:47Z
[FLINK-3888] cleanups in iterations and aggregators code
commit 3b1a5e55686f665b1c1bb90943b0f853e71eae82
Author: vasia <[email protected]>
Date: 2016-10-06T20:25:43Z
[FLINK-3888] add delta convergence criterion in the CollectionExecutor
commit 9f41af544eecae0c37ae9470f4ff26f19b5dbdc0
Author: vasia <[email protected]>
Date: 2016-10-06T21:00:38Z
[FLINK-3888] add ITCases for delta custom convergence
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
