Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2606#discussion_r83069609
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
---
@@ -1513,14 +1513,21 @@ private void
finalizeWorksetIteration(IterationDescriptor descr) {
String convAggName =
aggs.getConvergenceCriterionAggregatorName();
ConvergenceCriterion<?> convCriterion =
aggs.getConvergenceCriterion();
-
+
if (convCriterion != null || convAggName != null) {
- throw new CompilerException("Error: Cannot use custom
convergence criterion with workset iteration. Workset iterations have implicit
convergence criterion where workset is empty.");
+ if (convCriterion == null) {
+ throw new CompilerException("Error: Convergence
criterion aggregator set, but criterion is null.");
+ }
+ if (convAggName == null) {
+ throw new CompilerException("Error: Aggregator
convergence criterion set, but aggregator is null.");
+ }
+
+ syncConfig.setConvergenceCriterion(convAggName,
convCriterion);
}
headConfig.addIterationAggregator(WorksetEmptyConvergenceCriterion.AGGREGATOR_NAME,
new LongSumAggregator());
syncConfig.addIterationAggregator(WorksetEmptyConvergenceCriterion.AGGREGATOR_NAME,
new LongSumAggregator());
-
syncConfig.setConvergenceCriterion(WorksetEmptyConvergenceCriterion.AGGREGATOR_NAME,
new WorksetEmptyConvergenceCriterion());
+
syncConfig.setDefaultConvergenceCriterion(WorksetEmptyConvergenceCriterion.AGGREGATOR_NAME,
new WorksetEmptyConvergenceCriterion());
--- End diff --
Is it safe to use a fixed name for the aggregator? Could we not have
multiple iterations in a single job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
