Github user greghogan commented on a diff in the pull request:
    --- Diff: 
    @@ -56,11 +56,15 @@
        private SyncEventHandler eventHandler;
        private ConvergenceCriterion<Value> convergenceCriterion;
    +   private ConvergenceCriterion<Value> defaultConvergenceCriterion;
    --- End diff --
    Perhaps "implicit" instead of "default"? I feel like a default can be 
overridden, but the use here is for a system configured convergence implicit in 
how a delta iteration operates.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to