zjureel commented on code in PR #480:
URL: https://github.com/apache/flink-table-store/pull/480#discussion_r1089857616
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/file/predicate/LeafPredicate.java:
##########
@@ -84,7 +99,10 @@ public List<Object> literals() {
@Override
public boolean test(Object[] values) {
Review Comment:
The added cast function is for predicate push down, but I found it won't be
used when the `LeafPredicate` is converted to filter in file format such as
orc. I have updated `SchemaEvolutionUtil.createDataFilters` to convert
predicate value to underlying data value for different file format, please help
to review it, HTX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
