jiangxin369 commented on code in PR #202:
URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095393813
##########
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/ImputerTest.java:
##########
@@ -265,9 +265,7 @@ public void testNoValidDataOnMedianStrategy() {
final List<Row> trainData =
new ArrayList<>(
Arrays.asList(
- Row.of(Double.NaN, Float.NaN),
- Row.of(null, null),
- Row.of(1.0, 1.0f)));
+ Row.of(Double.NaN, 3.0f), Row.of(null, 2.0f),
Row.of(1.0, 1.0f)));
Review Comment:
Before the change, the 2 input columns both consisted of missing data, so
the both 2 columns are invalid. And the aggregation summaries of columns are
stored in a HashMap, which is not order-preserving, so we are not sure which
column is detected first and the test may fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
