jiangxin369 commented on code in PR #202:
URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095404730
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/countvectorizer/CountVectorizer.java:
##########
@@ -78,7 +80,11 @@ public CountVectorizerModel fit(Table... inputs) {
DataStream<CountVectorizerModelData> modelData =
DataStreamUtils.aggregate(
inputData,
- new VocabularyAggregator(getMinDF(), getMaxDF(),
getVocabularySize()));
+ new VocabularyAggregator(getMinDF(), getMaxDF(),
getVocabularySize()),
+ Types.TUPLE(
+ Types.LONG,
+ Types.MAP(Types.STRING,
Types.TUPLE(Types.LONG, Types.LONG))),
Review Comment:
IMO, since we are using generic types like Map, so the internal data types
are erased during the compilation, and Flink doesn't know which TypeInformation
to use in the Map.
Anyway, I agree to confirm with the related developers to find out if
there's a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
