jiangxin369 commented on code in PR #202:
URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095410791
##########
flink-ml-core/src/test/java/org/apache/flink/ml/api/GraphTest.java:
##########
@@ -49,13 +46,7 @@ public class GraphTest extends AbstractTestBase {
@Before
public void before() {
- Configuration config = new Configuration();
-
config.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH,
true);
- env = StreamExecutionEnvironment.getExecutionEnvironment(config);
- env.getConfig().enableObjectReuse();
- env.setParallelism(4);
- env.enableCheckpointing(100);
- env.setRestartStrategy(RestartStrategies.noRestart());
+ env = org.apache.flink.ml.util.TestUtils.getExecutionEnvironment();
Review Comment:
There may be some ambiguity here. The `org.apache.flink.ml.util.TestUtils`
here is under `flink-ml-core`. We also have a
`org.apache.flink.ml.util.TestUtils` under `flink-ml-lib`, and both of them
contains a `getExecutionEnvironment` method. This cause some code duplicates
but avoid introduce test-jar of `flink-ml-core` in `flink-ml-lib`.
I'm combining the `TestUtil` in `org.apache.flink.ml.api` and
`org.apache.flink.ml.util` under `flink-ml-core` to avoid using full package
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
