jiangxin369 commented on code in PR #203:
URL: https://github.com/apache/flink-ml/pull/203#discussion_r1097419512
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/util/quantile/QuantileSummary.java:
##########
@@ -395,12 +400,14 @@ public QueryResult(int index, long minRankAtIndex, double
percentile) {
* <li>delta: the maximum span of the rank.
* </ul>
*/
- private static class StatsTuple implements Serializable {
+ public static class StatsTuple implements Serializable {
private static final long serialVersionUID = 1L;
- private final double value;
+ private double value;
private long g;
private long delta;
+ public StatsTuple() {}
Review Comment:
No, it isn't. We don't need to make its member variable public because I
define the `TypeInfomation` for `StatsTuple` with `Types.POJO`. We need to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
