jiangxin369 commented on code in PR #203:
URL: https://github.com/apache/flink-ml/pull/203#discussion_r1100964409
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/util/QuantileSummary.java:
##########
@@ -367,6 +373,26 @@ public double getRelativeError() {
return relativeError;
}
+ public int getCompressThreshold() {
Review Comment:
We are not making this class POJO as the description in the below
conversation.
The get method is for unittests currently. But I didn't annotate it with
`VisibleForTesting` because I think it is reasonable for users to read the
information of a `QuantileSummary`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
