jiangxin369 commented on code in PR #203:
URL: https://github.com/apache/flink-ml/pull/203#discussion_r1097419512
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/util/quantile/QuantileSummary.java:
##########
@@ -395,12 +400,14 @@ public QueryResult(int index, long minRankAtIndex, double
percentile) {
* <li>delta: the maximum span of the rank.
* </ul>
*/
- private static class StatsTuple implements Serializable {
+ public static class StatsTuple implements Serializable {
private static final long serialVersionUID = 1L;
- private final double value;
+ private double value;
private long g;
private long delta;
+ public StatsTuple() {}
Review Comment:
No, it is not. It's needed to make the class can be used by `Types.POJO`. In
this way, we need to provide the field information of the class so that Flink
can access these fields by reflection and does not require all member variables
to be public.
But you remind me that actually, the `StatsTuple` is a standard POJO, I
don't need to define the TypeInfo by `Types.POJO`, making its member variables
public is a simpler way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
