akalash commented on code in PR #21999:
URL: https://github.com/apache/flink/pull/21999#discussion_r1115524445


##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskITCase.java:
##########
@@ -110,6 +116,42 @@ public void testFailInEndOfConstructor() throws Exception {
                                 .build(EXECUTOR_RESOURCE.getExecutor()));
     }
 
+    @Test
+    public void testAsyncExceptionCanBeHandledDuringRestoring() throws 
Exception {

Review Comment:
   I don't think that it is the right place for this test. Your test is just a 
simple unit test while this class is for IT tests. So I think `StreamTaskTest` 
is a better place for this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to