reswqa commented on code in PR #21999:
URL: https://github.com/apache/flink/pull/21999#discussion_r1115754252
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
##########
@@ -410,6 +410,42 @@ public CloseException() {
}
}
+ @Test
+ public void testAsyncExceptionCanBeHandledDuringRestoring() throws
Exception {
Review Comment:
```suggestion
public void testHandleAsyncExceptionDuringRestoring() throws Exception {
```
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
##########
@@ -410,6 +410,42 @@ public CloseException() {
}
}
+ @Test
+ public void testAsyncExceptionCanBeHandledDuringRestoring() throws
Exception {
+ MockEnvironment mockEnvironment = MockEnvironment.builder().build();
+ RuntimeException expectedException = new RuntimeException("RUNTIME
EXCEPTION");
+
+
mockEnvironment.setExpectedExternalFailureCause(AsynchronousException.class);
+ final String expectedErrorMessage = "EXPECTED_ERROR MESSAGE";
+
+ StreamTaskITCase.NoOpStreamTask noOpStreamTask =
Review Comment:
This is indeed not no-op, maybe should call it `initThrowExceptionTask` or
other more appropriate name
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
##########
@@ -410,6 +410,42 @@ public CloseException() {
}
}
+ @Test
+ public void testAsyncExceptionCanBeHandledDuringRestoring() throws
Exception {
+ MockEnvironment mockEnvironment = MockEnvironment.builder().build();
+ RuntimeException expectedException = new RuntimeException("RUNTIME
EXCEPTION");
Review Comment:
```suggestion
Throwable expectedException = new RuntimeException("RUNTIME
EXCEPTION");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
