RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1441946575
> Thanks @RocMarshal. If you like, you'd better migrate all the tests in `StreamTaskTest` to `Junit5` and `AssertJ` in a hotfix commit. No matter what, the newly introduced test should no longer use the `hamcrest` or `Junit` assertion according to our [Code Style and Quality Guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#tooling). Hi, @reswqa I'm fine to migrate the tests based on https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#tooling and I'm familiar to the migration process. What do you mean is that I should split the the comments-address and tests migration by different commits in the current PR ? I just want to confirm my confusion before we start the change, because I see you caught the hotfix-commit instead of hotfix-ticket. Thx you~. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
