[ 
https://issues.apache.org/jira/browse/FLINK-31519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702576#comment-17702576
 ] 

Jing Ge edited comment on FLINK-31519 at 3/20/23 11:49 AM:
-----------------------------------------------------------

IMHO, the watermark alignment should still be marked as beta, because:
 * only Kafka and Pulsar connectors support watermark alignment of source splits
 * there are some hints left in the source code for future work[1] 

 

[1]https://github.com/apache/flink/blob/0180284381bf7999781d542219d2a097f3cbc098/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitReader.java#L94


was (Author: jingge):
IHMO, the watermark alignment should still be marked as beta, because:
 * only Kafka and Pulsar connectors support watermark alignment of source splits
 * there are some hints left in the source code for future work[1] 

 

[1]https://github.com/apache/flink/blob/0180284381bf7999781d542219d2a097f3cbc098/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitReader.java#L94

> The watermark alignment docs is outdated after FLIP-217 finished
> ----------------------------------------------------------------
>
>                 Key: FLINK-31519
>                 URL: https://issues.apache.org/jira/browse/FLINK-31519
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.17.0
>            Reporter: Leonard Xu
>            Priority: Major
>             Fix For: 1.18.0, 1.17.1
>
>
> With FLIP-217 finished, the watermark alignment limitation has been resolved, 
> the *beta* tag and *warning note* can be safely removed.
> [1] 
> https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/dev/datastream/event-time/generating_watermarks/#watermark-alignment-_beta_



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to