[
https://issues.apache.org/jira/browse/FLINK-30897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lincoln lee updated FLINK-30897:
--------------------------------
Description:
As our [testing
guideline|https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests]
says we should 'Avoid timeouts in JUnit tests' but rather depend on the global
timeout in Azure. There're 10 itcases throughout the project that use the
'Timeout Rule' and 22 tests use the 'Deadline' to set local timeouts. We need
to check if we can change this dependency one by one
List of related test classes:
'Timeout Rule':
{code}
flink-end-to-end-tests-common-kafka (1 usage found)
org.apache.flink.tests.util.kafka (1 usage found)
SQLClientSchemaRegistryITCase.java (1 usage found)
78 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-glue-schema-registry-avro-test_2.12 (1 usage found)
org.apache.flink.glue.schema.registry.test (1 usage found)
GlueSchemaRegistryAvroKinesisITCase.java (1 usage found)
74 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-glue-schema-registry-json-test (1 usage found)
org.apache.flink.glue.schema.registry.test.json (1 usage found)
GlueSchemaRegistryJsonKinesisITCase.java (1 usage found)
68 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-runtime (1 usage found)
org.apache.flink.runtime.io.disk (1 usage found)
BatchShuffleReadBufferPoolTest.java (1 usage found)
41 @Rule public Timeout timeout = new Timeout(60,
TimeUnit.SECONDS);
flink-streaming-java (1 usage found)
org.apache.flink.streaming.api.operators.async (1 usage found)
AsyncWaitOperatorTest.java (1 usage found)
117 @Rule public Timeout timeoutRule = new Timeout(100,
TimeUnit.SECONDS);
flink-tests (5 usages found)
org.apache.flink.runtime.operators.lifecycle (3 usages found)
BoundedSourceITCase.java (1 usage found)
75 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
PartiallyFinishedSourcesITCase.java (1 usage found)
79 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
StopWithSavepointITCase.java (1 usage found)
103 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
org.apache.flink.test.runtime (2 usages found)
JoinDeadlockITCase.java (1 usage found)
39 @Rule public Timeout globalTimeout = new Timeout(120 *
1000); // Set timeout for deadlocks
SelfJoinDeadlockITCase.java (1 usage found)
46 @Rule public Timeout globalTimeout = new Timeout(120 *
1000); // Set timeout for deadlocks
{code}
'Deadline':
{code}
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/session/SessionManagerImplTest.java:2
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTaskTest.java:2
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/checkpointing/CheckpointedInputGateTest.java:2
flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/runtime/jobmanager/JMXJobManagerMetricTest.java:2
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java:4
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:2
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java:2
flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java:2
flink-end-to-end-tests/flink-metrics-availability-test/src/test/java/org/apache/flink/metrics/tests/MetricsAvailabilityITCase.java:6
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java:3
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java:2
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java:3
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointStressITCase.java:2
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java:3
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java:5
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/BatchingStateChangeUploadSchedulerTest.java:3
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/RetryingExecutorTest.java:2
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/BlobsCleanupITCase.java:2
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java:2
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java:2
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java:2
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHAJobRunITCase.java:2
{code}
was:
As our [testing
guideline|https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests]
says we should 'Avoid timeouts in JUnit tests' but rather depend on the global
timeout in Azure. There're 10 itcases throughout the project that use the
'Timeout Rule' to set local timeouts. We need to check if we can change this
dependency one by one
List of related test classes:
{code}
flink-end-to-end-tests-common-kafka (1 usage found)
org.apache.flink.tests.util.kafka (1 usage found)
SQLClientSchemaRegistryITCase.java (1 usage found)
78 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-glue-schema-registry-avro-test_2.12 (1 usage found)
org.apache.flink.glue.schema.registry.test (1 usage found)
GlueSchemaRegistryAvroKinesisITCase.java (1 usage found)
74 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-glue-schema-registry-json-test (1 usage found)
org.apache.flink.glue.schema.registry.test.json (1 usage found)
GlueSchemaRegistryJsonKinesisITCase.java (1 usage found)
68 @ClassRule public static final Timeout TIMEOUT = new
Timeout(10, TimeUnit.MINUTES);
flink-runtime (1 usage found)
org.apache.flink.runtime.io.disk (1 usage found)
BatchShuffleReadBufferPoolTest.java (1 usage found)
41 @Rule public Timeout timeout = new Timeout(60,
TimeUnit.SECONDS);
flink-streaming-java (1 usage found)
org.apache.flink.streaming.api.operators.async (1 usage found)
AsyncWaitOperatorTest.java (1 usage found)
117 @Rule public Timeout timeoutRule = new Timeout(100,
TimeUnit.SECONDS);
flink-tests (5 usages found)
org.apache.flink.runtime.operators.lifecycle (3 usages found)
BoundedSourceITCase.java (1 usage found)
75 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
PartiallyFinishedSourcesITCase.java (1 usage found)
79 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
StopWithSavepointITCase.java (1 usage found)
103 @Rule public Timeout timeoutRule = new Timeout(10,
TimeUnit.MINUTES);
org.apache.flink.test.runtime (2 usages found)
JoinDeadlockITCase.java (1 usage found)
39 @Rule public Timeout globalTimeout = new Timeout(120 *
1000); // Set timeout for deadlocks
SelfJoinDeadlockITCase.java (1 usage found)
46 @Rule public Timeout globalTimeout = new Timeout(120 *
1000); // Set timeout for deadlocks
{code}
> Avoid timeouts in JUnit tests
> -----------------------------
>
> Key: FLINK-30897
> URL: https://issues.apache.org/jira/browse/FLINK-30897
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Reporter: lincoln lee
> Priority: Minor
>
> As our [testing
> guideline|https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests]
> says we should 'Avoid timeouts in JUnit tests' but rather depend on the
> global timeout in Azure. There're 10 itcases throughout the project that use
> the 'Timeout Rule' and 22 tests use the 'Deadline' to set local timeouts. We
> need to check if we can change this dependency one by one
> List of related test classes:
> 'Timeout Rule':
> {code}
> flink-end-to-end-tests-common-kafka (1 usage found)
> org.apache.flink.tests.util.kafka (1 usage found)
> SQLClientSchemaRegistryITCase.java (1 usage found)
> 78 @ClassRule public static final Timeout TIMEOUT = new
> Timeout(10, TimeUnit.MINUTES);
> flink-glue-schema-registry-avro-test_2.12 (1 usage found)
> org.apache.flink.glue.schema.registry.test (1 usage found)
> GlueSchemaRegistryAvroKinesisITCase.java (1 usage found)
> 74 @ClassRule public static final Timeout TIMEOUT = new
> Timeout(10, TimeUnit.MINUTES);
> flink-glue-schema-registry-json-test (1 usage found)
> org.apache.flink.glue.schema.registry.test.json (1 usage found)
> GlueSchemaRegistryJsonKinesisITCase.java (1 usage found)
> 68 @ClassRule public static final Timeout TIMEOUT = new
> Timeout(10, TimeUnit.MINUTES);
> flink-runtime (1 usage found)
> org.apache.flink.runtime.io.disk (1 usage found)
> BatchShuffleReadBufferPoolTest.java (1 usage found)
> 41 @Rule public Timeout timeout = new Timeout(60,
> TimeUnit.SECONDS);
> flink-streaming-java (1 usage found)
> org.apache.flink.streaming.api.operators.async (1 usage found)
> AsyncWaitOperatorTest.java (1 usage found)
> 117 @Rule public Timeout timeoutRule = new Timeout(100,
> TimeUnit.SECONDS);
> flink-tests (5 usages found)
> org.apache.flink.runtime.operators.lifecycle (3 usages found)
> BoundedSourceITCase.java (1 usage found)
> 75 @Rule public Timeout timeoutRule = new Timeout(10,
> TimeUnit.MINUTES);
> PartiallyFinishedSourcesITCase.java (1 usage found)
> 79 @Rule public Timeout timeoutRule = new Timeout(10,
> TimeUnit.MINUTES);
> StopWithSavepointITCase.java (1 usage found)
> 103 @Rule public Timeout timeoutRule = new Timeout(10,
> TimeUnit.MINUTES);
> org.apache.flink.test.runtime (2 usages found)
> JoinDeadlockITCase.java (1 usage found)
> 39 @Rule public Timeout globalTimeout = new Timeout(120 *
> 1000); // Set timeout for deadlocks
> SelfJoinDeadlockITCase.java (1 usage found)
> 46 @Rule public Timeout globalTimeout = new Timeout(120 *
> 1000); // Set timeout for deadlocks
> {code}
> 'Deadline':
> {code}
> flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/session/SessionManagerImplTest.java:2
> flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTaskTest.java:2
> flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/checkpointing/CheckpointedInputGateTest.java:2
> flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/runtime/jobmanager/JMXJobManagerMetricTest.java:2
> flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java:4
> flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:2
> flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java:2
> flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java:2
> flink-end-to-end-tests/flink-metrics-availability-test/src/test/java/org/apache/flink/metrics/tests/MetricsAvailabilityITCase.java:6
> flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java:3
> flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java:2
> flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java:3
> flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointStressITCase.java:2
> flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java:3
> flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java:5
> flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/BatchingStateChangeUploadSchedulerTest.java:3
> flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/RetryingExecutorTest.java:2
> flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/BlobsCleanupITCase.java:2
> flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java:2
> flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java:2
> flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java:2
> flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHAJobRunITCase.java:2
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
